OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-08-09 13:22:24 +03:00
Code Activity

0023947: Eliminate trivial compiler warnings in MSVC++ with warning level 4

Browse Source 
Fix first subset of warnings (about 100)
- while(1) and similar constructs replaced by for(;;)
- some uninitialized variables corrected
Got rid of Warning C4189: local variable is initialised but not referenced
Corrected mistakes after getting rid of C4189 compiler warning
Corrected some mistakes that led to compiling errors
Fixed test case because of improvement message - removed unnecessary TODO.
Small fix: tabs have been replaced with whitespaces.
Added TODO for Windows platform
removed last TODO
Corrected mistakes, returned some #ifdef DEB code, fixed test case .
Restoring a few places which have been modified too much
Small grammar fix
Deleted unnecessary puts in bugs/end
This commit is contained in:
omy
2013-07-12 12:37:38 +04:00
parent a8195d65ba
commit 302f96fb0d
189 changed files with 455 additions and 1010 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Extrema/Extrema_FuncExtPS.cxx
View File

@@ -41,7 +41,6 @@ Extrema_FuncExtPS::Extrema_FuncExtPS (const gp_Pnt& P,
{
myP = P;
myS = (Adaptor3d_SurfacePtr)&S;
GeomAbs_SurfaceType aSType = S.GetType();
myPinit = Standard_True;
mySinit = Standard_True;
}
@@ -50,7 +49,6 @@ Extrema_FuncExtPS::Extrema_FuncExtPS (const gp_Pnt& P,
void Extrema_FuncExtPS::Initialize(const Adaptor3d_Surface& S)
{
myS = (Adaptor3d_SurfacePtr)&S;
GeomAbs_SurfaceType aSType = S.GetType();
mySinit = Standard_True;
myPoint.Clear();
mySqDist.Clear();

10
src/Extrema/Extrema_GenExtPS.cxx
View File

@@ -496,7 +496,6 @@ void Extrema_GenExtPS::GetGridPoints( const Adaptor3d_Surface& theSurf)
{
Handle(TColStd_HArray1OfReal) anArrKnots;
Standard_Integer aDegree = 0;
GeomAbs_CurveType aType = theSurf.BasisCurve()->Curve().GetType();
if(theSurf.BasisCurve()->Curve().GetType() == GeomAbs_BSplineCurve)
{
Handle(Geom_BSplineCurve) aBspl = theSurf.BasisCurve()->Curve().BSpline();
@@ -810,14 +809,10 @@ void Extrema_GenExtPS::FindSolution(const gp_Pnt& P,
math_Vector errors(1,2);
math_Vector root(1, 2);
Standard_Real eps = 1.e-9;
Standard_Integer nbsubsample = 11;
Standard_Integer aNbMaxIter = 100;
gp_Pnt PStart = theParams.Value();
Standard_Real DistStart = theParams.GetSqrDistance();
Standard_Real DistSol = DistStart;
math_FunctionSetRoot S (myF,UV,Tol,UVinf,UVsup, aNbMaxIter);
@@ -962,7 +957,7 @@ void Extrema_GenExtPS::Perform(const gp_Pnt& P)
Bnd_SphereUBTreeSelectorMin aSelector(mySphereArray, aSol);
//aSelector.SetMaxDist( RealLast() );
aSelector.DefineCheckPoint( P );
Standard_Integer aNbSel = mySphereUBTree->Select( aSelector );
mySphereUBTree->Select( aSelector );
//TODO: check if no solution in binary tree
Bnd_Sphere& aSph = aSelector.Sphere();
Standard_Real aU = myUParams->Value(aSph.U());
@@ -979,13 +974,12 @@ void Extrema_GenExtPS::Perform(const gp_Pnt& P)
Bnd_SphereUBTreeSelectorMax aSelector(mySphereArray, aSol);
//aSelector.SetMaxDist( RealLast() );
aSelector.DefineCheckPoint( P );
Standard_Integer aNbSel = mySphereUBTree->Select( aSelector );
mySphereUBTree->Select( aSelector );
//TODO: check if no solution in binary tree
Bnd_Sphere& aSph = aSelector.Sphere();
Standard_Real aU = myUParams->Value(aSph.U());
Standard_Real aV = myVParams->Value(aSph.V());
Extrema_POnSurfParams aParams(aU, aV, myS->Value(aU, aV));
aParams.SetSqrDistance(P.SquareDistance(aParams.Value()));
aParams.SetIndices(aSph.U(), aSph.V());