OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-08-04 13:13:25 +03:00
Code Activity

0030550: Coding - Integer overflow in Standard_CString HashCodes

Browse Source 
0030551: Foundation Classes - Integer overflow in NCollection_CellFilter HashCode

Signed integers are not used in hash code functions now to prevent undefined behavior on left shift operations with signed integers.
A possibility of negative values of hash codes is eliminated.
INT_MAX → IntegerLast() in hash code functions.
All found hash code functions behaves uniformly now: they return a value in the range [1, theUpperBound]. Relevant comments are added to such functions.
This commit is contained in:
tiv
2019-03-28 12:42:41 +03:00
committed by bugmaster
parent 833034f301
commit 2b2be3fb82
89 changed files with 878 additions and 580 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/TObj/TObj_Common.hxx
View File

@@ -31,10 +31,14 @@
//! Methods inline implimentation for HExtendedString
inline Standard_Integer HashCode (const Handle(TCollection_HExtendedString)& theStr,
const Standard_Integer theBnd)
//! Computes a hash code for the given handle referred to extended string, in the range [1, theUpperBound]
//! @param theHExtendedString the handle referred to extended string which hash code is to be computed
//! @param theUpperBound the upper bound of the range a computing hash code must be within
//! @return a computed hash code, in the range [1, theUpperBound]
inline Standard_Integer HashCode (const Handle (TCollection_HExtendedString) & theHExtendedString,
const Standard_Integer theUpperBound)
{
return TCollection_ExtendedString::HashCode(theStr->String(), theBnd);
return TCollection_ExtendedString::HashCode (theHExtendedString->String(), theUpperBound);
}
inline Standard_Boolean IsEqual (const Handle(TCollection_HExtendedString)& theStr1,