OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-08-09 13:22:24 +03:00
Code Activity

0030550: Coding - Integer overflow in Standard_CString HashCodes

Browse Source 
0030551: Foundation Classes - Integer overflow in NCollection_CellFilter HashCode

Signed integers are not used in hash code functions now to prevent undefined behavior on left shift operations with signed integers.
A possibility of negative values of hash codes is eliminated.
INT_MAX → IntegerLast() in hash code functions.
All found hash code functions behaves uniformly now: they return a value in the range [1, theUpperBound]. Relevant comments are added to such functions.
This commit is contained in:
tiv
2019-03-28 12:42:41 +03:00
committed by bugmaster
parent 833034f301
commit 2b2be3fb82
89 changed files with 878 additions and 580 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/Poly/Poly_MakeLoops.hxx
View File

@@ -250,13 +250,13 @@ private:
TColStd_PackedMapOfInteger myHangIndices;
};
/**
* HashCode method is needed for maps
*/
inline Standard_Integer HashCode(const Poly_MakeLoops::Link& theKey,
int theLimit)
//! Computes a hash code for the given link, in the range [1, theUpperBound]
//! @param theLink the link which hash code is to be computed
//! @param theUpperBound the upper bound of the range a computing hash code must be within
//! @return a computed hash code, in the range [1, theUpperBound]
inline Standard_Integer HashCode (const Poly_MakeLoops::Link& theLink, const Standard_Integer theUpperBound)
{
return HashCode(theKey.node1 + theKey.node2, theLimit);
return HashCode (theLink.node1 + theLink.node2, theUpperBound);
}
/**