OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-05 18:16:23 +03:00
Code Packages Releases Activity

0030980: Data Exchange - global-buffer-overflow reported by Clang address sanitizer in iges_newchar()

Browse Source 
Avoid unnecessary copying of characters with zero-length string literal as source
This commit is contained in:
abv 2019-09-19 07:07:13 +03:00 committed by bugmaster
parent 0904aa6395
commit 25093c3f54
1 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/IGESFile/structiges.c
View File

@ -87,10 +87,10 @@ static struct dirpage *curpage;
/* Utilitaire : Reservation de caracteres /* Utilitaire : Reservation de caracteres
Remplace suite de mini-malloc par gestion de page */ Remplace suite de mini-malloc par gestion de page */
char* iges_newchar (char* newtext, int lentext) static char* iges_newchar (int lentext)
{ {
int i, lnt; int lnt = onecarpage->used;
if ((lnt = onecarpage->used) > Maxcar-lentext-1) { /* allouer nouvelle page */ if (lnt > Maxcar-lentext-1) { /* allouer nouvelle page */
struct carpage *newpage; struct carpage *newpage;
unsigned int sizepage = sizeof(struct carpage); unsigned int sizepage = sizeof(struct carpage);
if (lentext >= Maxcar) sizepage += (lentext+1 - Maxcar); if (lentext >= Maxcar) sizepage += (lentext+1 - Maxcar);
@ -102,9 +102,8 @@ char* iges_newchar (char* newtext, int lentext)
restext = onecarpage->cars + lnt; restext = onecarpage->cars + lnt;
onecarpage->used = (lnt + lentext + 1); onecarpage->used = (lnt + lentext + 1);
/* strcpy */ /* strcpy */
for (i = lentext-1; i >= 0; i --) restext[i] = newtext[i];
restext[lentext] = '\0'; restext[lentext] = '\0';
return (restext); return restext;
} }
@ -193,9 +192,14 @@ void iges_curpart (int dnum)
void iges_newparam (int typarg, int longval, char *parval) void iges_newparam (int typarg, int longval, char *parval)
{ {
char *newval; char *newval;
int i;
if (curlist == NULL) return; /* non defini : abandon */ if (curlist == NULL) return; /* non defini : abandon */
newval = iges_newchar(parval,longval);
/* curparam = (struct oneparam*) malloc ( sizeof(struct oneparam) ); */ newval = iges_newchar(longval);
for (i = 0; i < longval; i++) newval[i] = parval[i];
/* curparam = (struct oneparam*) malloc ( sizeof(struct oneparam) ); */
if (oneparpage->used > Maxpar) { if (oneparpage->used > Maxpar) {
struct parpage* newparpage; struct parpage* newparpage;
newparpage = (struct parpage*) malloc ( sizeof(struct parpage) ); newparpage = (struct parpage*) malloc ( sizeof(struct parpage) );
@ -223,7 +227,7 @@ void iges_addparam (int longval, char* parval)
oldval = curparam->parval; oldval = curparam->parval;
long0 = (int)strlen(oldval); long0 = (int)strlen(oldval);
/* newval = (char*) malloc(long0+longval+1); */ /* newval = (char*) malloc(long0+longval+1); */
newval = iges_newchar("",long0+longval+1); newval = iges_newchar (long0 + longval + 1);
for (i = 0; i < long0; i ++) newval[i] = oldval[i]; for (i = 0; i < long0; i ++) newval[i] = oldval[i];
for (i = 0; i < longval; i ++) newval[i+long0] = parval[i]; for (i = 0; i < longval; i ++) newval[i+long0] = parval[i];
newval[long0+longval] = '\0'; newval[long0+longval] = '\0';