OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-03 17:56:21 +03:00
Code Packages Releases Activity

0031496: Modeling Algorithms - BRepAlgo::ConcatenateWireC0() crashes

Browse Source 
BRepAlgo.cxx: fixing of wrong treatment of reversed edges
bug31496: test case added
This commit is contained in:
ifv 2020-04-13 14:34:12 +03:00 committed by bugmaster
parent 13dd311c9b
commit 1f9cb9f999
2 changed files with 31 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/BRepAlgo/BRepAlgo.cxx
View File

@ -421,9 +421,18 @@ TopoDS_Edge BRepAlgo::ConcatenateWireC0(const TopoDS_Wire& aWire)
isReverse = !IsFwdSeq(1); isReverse = !IsFwdSeq(1);
} }
TopoDS_Vertex FirstVtx_final = FirstVertex; TopoDS_Vertex FirstVtx_final, LastVtx_final;
if (isReverse)
{
FirstVtx_final = LastVertex;
LastVtx_final = FirstVertex;
}
else
{
FirstVtx_final = FirstVertex;
LastVtx_final = LastVertex;
}
FirstVtx_final.Orientation(TopAbs_FORWARD); FirstVtx_final.Orientation(TopAbs_FORWARD);
TopoDS_Vertex LastVtx_final = LastVertex;
LastVtx_final.Orientation(TopAbs_REVERSED); LastVtx_final.Orientation(TopAbs_REVERSED);
if (CurveSeq.IsEmpty()) if (CurveSeq.IsEmpty())
@ -497,6 +506,9 @@ TopoDS_Edge BRepAlgo::ConcatenateWireC0(const TopoDS_Wire& aWire)
concatcurve->SetValue(concatcurve->Lower(), Concat.BSplineCurve()); concatcurve->SetValue(concatcurve->Lower(), Concat.BSplineCurve());
} }
if (isReverse) {
concatcurve->ChangeValue(concatcurve->Lower())->Reverse();
}
ResEdge = BRepLib_MakeEdge(concatcurve->Value(concatcurve->Lower()), ResEdge = BRepLib_MakeEdge(concatcurve->Value(concatcurve->Lower()),
FirstVtx_final, LastVtx_final, FirstVtx_final, LastVtx_final,
concatcurve->Value(concatcurve->Lower())->FirstParameter(), concatcurve->Value(concatcurve->Lower())->FirstParameter(),

17
tests/bugs/modalg_7/bug31496 Normal file
View File

@ -0,0 +1,17 @@
puts "==================================================="
puts "0031496: Modeling Algorithms - BRepAlgo::ConcatenateWireC0() crashes"
puts "==================================================="
vertex v1 0 0 0
vertex v2 1 0 0
vertex v3 2 0 0
vertex v4 3 0 0
edge e1 v1 v2
edge e2 v2 v3
edge e3 v3 v4
wire w e1 e2 e3
invert w
concatC0wire e w
checknbshapes e -vertex 2 -edge 1
nurbsconvert w w
concatC0wire e w
checknbshapes e -vertex 2 -edge 1