OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-03 17:56:21 +03:00
Code Packages Releases Activity

0032561: Modelling Algorithms - UnifySameDomain does nothing while it is expected to union two pairs of faces

Browse Source 
Correct method ShapeUpgrade_UnifySameDomain::UnifyFaces: when creating the Edge-Face map of initial shape, count each face only once.
This commit is contained in:
jgv 2021-09-10 19:30:38 +03:00 committed by smoskvin
parent e2d6f0e37a
commit 1e6b2065b5
3 changed files with 25 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/ShapeUpgrade/ShapeUpgrade_UnifySameDomain.cxx
View File

@ -2573,7 +2573,11 @@ void ShapeUpgrade_UnifySameDomain::UnifyFaces()
{ {
// creating map of edge faces for the whole shape // creating map of edge faces for the whole shape
TopTools_IndexedDataMapOfShapeListOfShape aGMapEdgeFaces; TopTools_IndexedDataMapOfShapeListOfShape aGMapEdgeFaces;
TopExp::MapShapesAndAncestors(myShape, TopAbs_EDGE, TopAbs_FACE, aGMapEdgeFaces);
TopTools_IndexedMapOfShape aFaceMap;
TopExp::MapShapes (myShape, TopAbs_FACE, aFaceMap);
for (Standard_Integer i = 1; i <= aFaceMap.Extent(); i++)
TopExp::MapShapesAndAncestors (aFaceMap(i), TopAbs_EDGE, TopAbs_FACE, aGMapEdgeFaces);
// unify faces in each shell separately // unify faces in each shell separately
TopExp_Explorer exps; TopExp_Explorer exps;

4
tests/boolean/removefeatures/C5
View File

@ -8,7 +8,7 @@ compound s_11 s_12 s_17 gap2
removefeatures res1 s gap1 removefeatures res1 s gap1
checkshape res1 checkshape res1
checkprops res1 -s 1200 -v 1875 checkprops res1 -s 1200 -v 1875
checknbshapes res1 -vertex 21 -edge 35 -wire 17 -face 17 -shell 2 -solid 2 checknbshapes res1 -vertex 19 -edge 31 -wire 15 -face 15 -shell 2 -solid 2
CheckIsFeatureRemoved gap1 {e f} CheckIsFeatureRemoved gap1 {e f}
# check that the common face is still shared # check that the common face is still shared
@ -32,7 +32,7 @@ checkprops m1 -s 600 -v 1000
removefeatures res2 s gap2 removefeatures res2 s gap2
checkshape res2 checkshape res2
checkprops res2 -s 1200 -v 1875 checkprops res2 -s 1200 -v 1875
checknbshapes res2 -vertex 21 -edge 35 -wire 17 -face 17 -shell 2 -solid 2 checknbshapes res2 -vertex 19 -edge 31 -wire 15 -face 15 -shell 2 -solid 2
CheckIsFeatureRemoved gap2 {e f} CheckIsFeatureRemoved gap2 {e f}
# get history of the operation # get history of the operation

18
tests/bugs/heal/bug32561 Normal file
View File

@ -0,0 +1,18 @@
puts "======================================================================================="
puts "OCC32561: UnifySameDomain does nothing while it is expected to union two pairs of faces"
puts "======================================================================================="
puts ""
restore [locate_data_file bug32561.brep] a
unifysamedom result a
checkshape result
checknbshapes result -t -solid 64 -shell 64 -face 233 -wire 233 -edge 284 -vertex 116
set tolres [checkmaxtol result]
if { ${tolres} > 2.e-7} {
puts "Error: bad tolerance of result"
}