OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-03 17:56:21 +03:00
Code Packages Releases Activity

0033146: Modeling Algorithms - 2D Offset with arc-lin approximation fails on open B-spline edge

Browse Source 
Added additional conditions to avoid crash.
Added a test case.
This commit is contained in:
astromko 2024-04-17 10:46:06 +01:00 committed by dpasukhi
parent fc51ce503e
commit 1db93f640e
2 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/BRepFill/BRepFill_OffsetWire.cxx
View File

@ -926,7 +926,7 @@ void BRepFill_OffsetWire::PerformWithBiLo
if (StartOnEdge) { if (StartOnEdge) {
Standard_Boolean Start = 1; Standard_Boolean Start = 1;
Trim.AddOrConfuse(Start, E[0], E[1], Params); Trim.AddOrConfuse(Start, E[0], E[1], Params);
if (Params.Length() == Vertices.Length()) if (Params.Length() == Vertices.Length() && Params.Length() != 0)
Vertices.SetValue(1,VS); Vertices.SetValue(1,VS);
else else
@ -936,7 +936,7 @@ void BRepFill_OffsetWire::PerformWithBiLo
if (EndOnEdge) { if (EndOnEdge) {
Standard_Boolean Start = 0; Standard_Boolean Start = 0;
Trim.AddOrConfuse(Start, E[0], E[1], Params); Trim.AddOrConfuse(Start, E[0], E[1], Params);
if (Params.Length() == Vertices.Length()) if (Params.Length() == Vertices.Length() && Params.Length() != 0)
Vertices.SetValue(Params.Length(),VE); Vertices.SetValue(Params.Length(),VE);
else else
@ -962,7 +962,7 @@ void BRepFill_OffsetWire::PerformWithBiLo
// Storage of vertices on parallel edges. // Storage of vertices on parallel edges.
// fill MapBis and MapVerPar. // fill MapBis and MapVerPar.
//---------------------------------------------- //----------------------------------------------
if (!Vertices.IsEmpty()) { if (!Vertices.IsEmpty() && Params.Length() == Vertices.Length()) {
for (k = 0; k <= 1; k++) { for (k = 0; k <= 1; k++) {
if (!MapBis.IsBound(E[k])) { if (!MapBis.IsBound(E[k])) {
MapBis .Bind(E[k],EmptySeq); MapBis .Bind(E[k],EmptySeq);
@ -1298,7 +1298,7 @@ void BRepFill_OffsetWire::UpdateDetromp (BRepFill_DataMapOfOrientedShapeListOfSh
ii++; ii++;
} }
while (ii <= Vertices.Length()) { while (ii <= Vertices.Length() && ii <= Params.Length()) {
U2 = Params.Value(ii).X(); U2 = Params.Value(ii).X();
V2 = TopoDS::Vertex(Vertices.Value(ii)); V2 = TopoDS::Vertex(Vertices.Value(ii));

10
tests/bugs/modalg_8/bug33146 Normal file
View File

@ -0,0 +1,10 @@
puts "==============================================================="
puts "0033146: Modeling Algorithms - 2D Offset with arc-lin approximation fails on open B-spline edge"
puts "==============================================================="
puts ""
pload MODELING
restore [locate_data_file bug33146.brep] a
wire a a
openoffset result a 1 1. -approx
checkview -display result_1 -2d -path ${imagedir}/${test_image}.png