0024427: Wrong section curves

Incorrect curve is got after Decompose method applying. This method's using should be restrict.
Decomposition is required if intersection curve contains some parts, where U-parameter on quadric surface changes too sharply.

Decompose method is called for Cone and Sphere only (it does not require for Cylinder).

Comments are changed by jgv.

Test case for issue CR24427

Added test case bugs/moddata_3/bug24427_2

Compiler warning is liquidated.
Test is corrected.

src/IntStart/IntStart_SearchOnBoundaries.gxx

@@ -475,7 +475,9 @@ void BoundedArc (const TheArc& A,
     }
 
     if (Nbi==1) {
-      if (pardeb == Pdeb && parfin == Pfin) {
+      if (  (Abs(pardeb - Pdeb) < Precision::PConfusion()) &&
+            (Abs(parfin - Pfin) < Precision::PConfusion()))
+      {
         Arcsol=Standard_True;
       }
     }

tests/bugs/modalg_4/bug825

@@ -17,19 +17,60 @@ if { [ catch { set info_result [OCC825 a1 a2 a3 res1 res2 0] } ] } {
     puts "Faulty OCC825"
 } else {
     if { [regexp {FAILED} $info_result] } {
-	puts "Faulty OCC825"
+        puts "Faulty OCC825"
     }
 
     set ExplodeList [explode res1]
     if {[llength ${ExplodeList}] < 1} {
-	puts "Faulty OCC825"
+        puts "Faulty OCC825"
     }
 
     set ExplodeList [explode res2]
     if {[llength ${ExplodeList}] < 1} {
-	puts "Faulty OCC825"
+        puts "Faulty OCC825"
     }
     checkshape res1
+
+    set nbFace_exp 0
+    set nbShell_exp 0
+    set nbSolid_exp 0
+    set nbCompSolid_exp 0
+    set nbCompound_exp 1
+    set nbShape_exp 1
+        
+    set nb_info [nbshapes res1]
+    regexp {FACE +: +([-0-9.+eE]+)} $nb_info full nb_face
+    regexp {SHELL +: +([-0-9.+eE]+)} $nb_info full nb_shell
+    regexp {SOLID +: +([-0-9.+eE]+)} $nb_info full nb_solid
+    regexp {COMPSOLID +: +([-0-9.+eE]+)} $nb_info full nbCompSolid
+    regexp {COMPOUND +: +([-0-9.+eE]+)} $nb_info full nb_compound
+    regexp {SHAPE +: +([-0-9.+eE]+)} $nb_info full nb_Shape
+        
+    if { $nb_face != $nbFace_exp } {
+      puts [format "Faulty : result must contain %s FACE(S), but it contains %s only." $nbFace_exp $nb_face]
+    }
+
+    if { $nb_shell != $nbShell_exp } {
+      puts [format "Faulty : result must contain %s SHELL(S), but it contains %s only." $nbShell_exp $nb_shell]
+    }
+    
+    if { $nb_solid != $nbSolid_exp } {
+      puts [format "Faulty : result must contain %s SOLID(S), but it contains %s only." $nbSolid_exp $nb_solid]
+    }
+
+    if { $nbCompSolid != $nbCompSolid_exp } {
+      puts [format "Faulty : result must contain %s COMPSOLID(S), but it contains %s only." $nbCompSolid_exp $nbCompSolid]
+    }
+
+    if { $nb_compound != $nbCompound_exp } {
+      puts [format "Faulty : result must contain %s COMPOUND(S), but it contains %s only." $nbCompound_exp $nb_compound]
+    }
+
+    if { $nb_Shape != $nbShape_exp } {
+      puts [format "Faulty : result must contain %s SHAPE(S), but it contains %s only." $nbShape_exp $nb_Shape]
+    }
+
+
     renamevar res2 result
 }
 

tests/bugs/moddata_3/bug24427_1

@@ -0,0 +1,79 @@
+puts "========="
+puts "CR24427"
+puts "========="
+puts ""
+###############################
+## Wrong section curves
+###############################
+
+restore [locate_data_file bug24427_b1.brep] b1
+restore [locate_data_file bug24427_b2.brep] b2
+
+mksurface s1 b1
+mksurface s2 b2
+
+bop b1 b2
+bopsection ressec
+
+explode ressec e
+mkcurve rr ressec_1
+
+puts "First test"
+dlog reset
+dlog on
+xdistcs rr s1 0 1 100
+
+set Log1 [dlog get]
+
+set List1 [split ${Log1} {TD= \t\n}]
+
+set L1 [llength ${List1}]
+set L2 10
+set L3 5
+set N [expr (${L1} - ${L2})/${L3} + 1]
+set Tolerance 1.0e-7
+set D_good 0.
+
+for {set i 1} {${i} <= ${N}} {incr i} {
+   set j1 [expr ${L2} + (${i}-1)*${L3}]
+   set j2 [expr ${j1} + 2]
+   set T [lindex ${List1} ${j1}]
+   set D [lindex ${List1} ${j2}]
+   puts "i=${i} j1=${j1} j2=${j2} T=${T} D=${D}"
+   if { [expr abs(${D} - ${D_good})] > ${Tolerance} } {
+      puts "Error: i=${i} T=${T} D=${D}"
+   }
+}
+
+
+puts "Second test"
+dlog reset
+dlog on
+xdistcs rr s2 0 1 100
+set Log2 [dlog get]
+
+set List2 [split ${Log2} {TD= \t\n}]
+
+set L1 [llength ${List2}]
+set L2 10
+set L3 5
+set N [expr (${L1} - ${L2})/${L3} + 1]
+set Tolerance 1.0e-7
+set D_good 0.
+
+for {set i 1} {${i} <= ${N}} {incr i} {
+   set j1 [expr ${L2} + (${i}-1)*${L3}]
+   set j2 [expr ${j1} + 2]
+   set T [lindex ${List2} ${j1}]
+   set D [lindex ${List2} ${j2}]
+   puts "i=${i} j1=${j1} j2=${j2} T=${T} D=${D}"
+   if { [expr abs(${D} - ${D_good})] > ${Tolerance} } {
+      puts "Error: i=${i} T=${T} D=${D}"
+   }
+}
+
+donly rr s1t s2t
+
+smallview
+fit
+set only_screen_axo 1

tests/bugs/moddata_3/bug24427_2

@@ -0,0 +1,79 @@
+puts "========="
+puts "CR24427"
+puts "========="
+puts ""
+###############################
+## Wrong section curves
+###############################
+
+restore [locate_data_file bug24427_b1.brep] b1
+restore [locate_data_file bug24427_b2.brep] b2
+
+mksurface s1 b1
+mksurface s2 b2
+
+trim s1t s1 0 3.1415926535897931 3.3684854563490672 3.9269908169872507
+trim s2t s2 0 3.1415926535897931 -1.0598124096115453e-015 0.013271150216666670
+
+intersect i s1t s2t
+don s1t s2t i
+
+puts "First test"
+dlog reset
+dlog on
+xdistcs i s1 0 1 10
+
+set Log1 [dlog get]
+
+set List1 [split ${Log1} {TD= \t\n}]
+
+set L1 [llength ${List1}]
+set L2 10
+set L3 5
+set N [expr (${L1} - ${L2})/${L3} + 1]
+set Tolerance 1.0e-7
+set D_good 0.
+
+for {set i 1} {${i} <= ${N}} {incr i} {
+   set j1 [expr ${L2} + (${i}-1)*${L3}]
+   set j2 [expr ${j1} + 2]
+   set T [lindex ${List1} ${j1}]
+   set D [lindex ${List1} ${j2}]
+   puts "i=${i} j1=${j1} j2=${j2} T=${T} D=${D}"
+   if { [expr abs(${D} - ${D_good})] > ${Tolerance} } {
+      puts "Error: i=${i} T=${T} D=${D}"
+   }
+}
+
+
+puts "Second test"
+dlog reset
+dlog on
+xdistcs i s2 0 1 10
+set Log2 [dlog get]
+
+set List2 [split ${Log2} {TD= \t\n}]
+
+set L1 [llength ${List2}]
+set L2 10
+set L3 5
+set N [expr (${L1} - ${L2})/${L3} + 1]
+set Tolerance 1.0e-7
+set D_good 0.
+
+for {set i 1} {${i} <= ${N}} {incr i} {
+   set j1 [expr ${L2} + (${i}-1)*${L3}]
+   set j2 [expr ${j1} + 2]
+   set T [lindex ${List2} ${j1}]
+   set D [lindex ${List2} ${j2}]
+   puts "i=${i} j1=${j1} j2=${j2} T=${T} D=${D}"
+   if { [expr abs(${D} - ${D_good})] > ${Tolerance} } {
+      puts "Error: i=${i} T=${T} D=${D}"
+   }
+}
+
+donly i s1t s2t
+
+smallview
+fit
+set only_screen_axo 1