From ddf81f2b933caf9904fbc7455cb591c6f463187d Mon Sep 17 00:00:00 2001 From: Pasukhin Dmitry Date: Wed, 12 Mar 2025 22:18:44 +0000 Subject: [PATCH] Configuration - Remove -symbolic linker flag (#432) Updated VCPKG workflow to follow the type of linking with the triplet. Removed symbolic linker flag. As a result downgrade of performance. The symbolic flag has high risk of instability, better to disable. --- .github/workflows/build-occt-with-vcpkg.yml | 1 + adm/cmake/occt_defs_flags.cmake | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-occt-with-vcpkg.yml b/.github/workflows/build-occt-with-vcpkg.yml index 32ed7a1586..a4eee6d4f0 100644 --- a/.github/workflows/build-occt-with-vcpkg.yml +++ b/.github/workflows/build-occt-with-vcpkg.yml @@ -114,6 +114,7 @@ jobs: -DUSE_TK=OFF \ -DBUILD_USE_PCH=ON \ -DBUILD_INCLUDE_SYMLINK=ON \ + -DBUILD_LIBRARY_TYPE="Static" \ -DINSTALL_DIR=${{ github.workspace }}/install-${{ matrix.build_type }} \ -DUSE_DRACO=ON \ -DUSE_FFMPEG=ON \ diff --git a/adm/cmake/occt_defs_flags.cmake b/adm/cmake/occt_defs_flags.cmake index 0d14ab1d2b..9802101623 100644 --- a/adm/cmake/occt_defs_flags.cmake +++ b/adm/cmake/occt_defs_flags.cmake @@ -172,7 +172,7 @@ elseif (CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX OR (CMAKE_CXX_COMPIL if (APPLE) set (CMAKE_SHARED_LINKER_FLAGS "-lm ${CMAKE_SHARED_LINKER_FLAGS}") elseif(NOT WIN32) - set (CMAKE_SHARED_LINKER_FLAGS "-lm -Wl,-Bsymbolic ${CMAKE_SHARED_LINKER_FLAGS}") + set (CMAKE_SHARED_LINKER_FLAGS "-lm ${CMAKE_SHARED_LINKER_FLAGS}") endif() endif() endif()