From a4d484a93a70e11c17c9a42674716cbd48f4a4f1 Mon Sep 17 00:00:00 2001
From: astromko <astromko@opencascade.com>
Date: Mon, 1 Apr 2024 13:34:16 +0000
Subject: [PATCH] 0033591: Modeling Algorithms - Regression: old surface is not
 removed after translation or rotation with geometry copying

Removed unnecessary condition that was added by an earlier fix.
Added a test case.
---
 src/BRepTools/BRepTools_TrsfModification.cxx |  4 ----
 src/BRepTools/BRepTools_TrsfModification.hxx |  5 +----
 tests/bugs/modalg_8/bug33591                 | 18 ++++++++++++++++++
 3 files changed, 19 insertions(+), 8 deletions(-)
 create mode 100644 tests/bugs/modalg_8/bug33591

diff --git a/src/BRepTools/BRepTools_TrsfModification.cxx b/src/BRepTools/BRepTools_TrsfModification.cxx
index 63ac4565f4..31876b5422 100644
--- a/src/BRepTools/BRepTools_TrsfModification.cxx
+++ b/src/BRepTools/BRepTools_TrsfModification.cxx
@@ -307,10 +307,6 @@ Standard_Boolean BRepTools_TrsfModification::NewCurve
 {
   Standard_Real f,l;
   C = BRep_Tool::Curve(E,L,f,l);
-  if (C.IsNull())
-  {
-    return Standard_False;
-  }
 
   Tol = BRep_Tool::Tolerance(E);
   Tol *= Abs(myTrsf.ScaleFactor());
diff --git a/src/BRepTools/BRepTools_TrsfModification.hxx b/src/BRepTools/BRepTools_TrsfModification.hxx
index 2215b3d03b..32669d7df5 100644
--- a/src/BRepTools/BRepTools_TrsfModification.hxx
+++ b/src/BRepTools/BRepTools_TrsfModification.hxx
@@ -82,13 +82,10 @@ public:
   //! - P is a new polygon on triangulation
   Standard_EXPORT Standard_Boolean NewPolygonOnTriangulation(const TopoDS_Edge& E, const TopoDS_Face& F, Handle(Poly_PolygonOnTriangulation)& P) Standard_OVERRIDE;
 
-  //! Returns true if the edge E has been modified.
-  //! If the edge has been modified:
+  //! Always returns true indicating that the edge E is always modified.
   //! - C is the new geometric support of the edge,
   //! - L is the new location, and
   //! - Tol is the new tolerance.
-  //! If the edge has not been modified, this function
-  //! returns false, and the values of C, L and Tol are not significant.
   Standard_EXPORT Standard_Boolean NewCurve (const TopoDS_Edge& E, Handle(Geom_Curve)& C, TopLoc_Location& L, Standard_Real& Tol) Standard_OVERRIDE;
   
   //! Returns true if the vertex V has been modified.
diff --git a/tests/bugs/modalg_8/bug33591 b/tests/bugs/modalg_8/bug33591
new file mode 100644
index 0000000000..e2a67e0ef8
--- /dev/null
+++ b/tests/bugs/modalg_8/bug33591
@@ -0,0 +1,18 @@
+puts "========================"
+puts "0033591: Modeling Algorithms - Regression: old surface is not removed after translation or rotation with geometry copying"
+puts "========================"
+puts ""
+
+pload MODELING
+psphere Sphere_1 80
+trotate Sphere_1  0 0 0  0 1 0  90 -copy
+ttranslate Sphere_1 0 0 200 -copy
+
+catch {dump Sphere_1} dumpOutput
+if {[regexp {Dump of ([0-9]+) surfaces} $dumpOutput match num]} {
+  set numSurfaces $num
+}
+
+if {$numSurfaces != 1} {
+  puts "Error: The number of surfaces must be 1"
+}