From 4efafd1f3aae185769b991854f05b0ec28e71b44 Mon Sep 17 00:00:00 2001 From: gka Date: Wed, 4 Dec 2013 10:47:40 +0400 Subject: [PATCH] 0024283: STEP read failes to read unbound advanced_face Fix to avoid exception if sphere is written without bounds. --- .../RWStepShape_RWAdvancedFace.cxx | 15 +++++++++------ tests/bugs/step/bug24283_1 | 11 +++++++++++ tests/bugs/step/bug24283_2 | 19 +++++++++++++++++++ 3 files changed, 39 insertions(+), 6 deletions(-) create mode 100644 tests/bugs/step/bug24283_1 create mode 100644 tests/bugs/step/bug24283_2 diff --git a/src/RWStepShape/RWStepShape_RWAdvancedFace.cxx b/src/RWStepShape/RWStepShape_RWAdvancedFace.cxx index 0dec59b41c..c0990a1569 100755 --- a/src/RWStepShape/RWStepShape_RWAdvancedFace.cxx +++ b/src/RWStepShape/RWStepShape_RWAdvancedFace.cxx @@ -55,12 +55,15 @@ void RWStepShape_RWAdvancedFace::ReadStep Standard_Integer nsub2; if (data->ReadSubList (num,2,"bounds",ach,nsub2)) { Standard_Integer nb2 = data->NbParams(nsub2); - aBounds = new StepShape_HArray1OfFaceBound (1, nb2); - for (Standard_Integer i2 = 1; i2 <= nb2; i2 ++) { - //szv#4:S4163:12Mar99 `Standard_Boolean stat2 =` not needed - if (data->ReadEntity (nsub2, i2,"face_bound", ach, STANDARD_TYPE(StepShape_FaceBound), anent2)) - aBounds->SetValue(i2, anent2); - } + if( nb2) + { + aBounds = new StepShape_HArray1OfFaceBound (1, nb2); + for (Standard_Integer i2 = 1; i2 <= nb2; i2 ++) { + //szv#4:S4163:12Mar99 `Standard_Boolean stat2 =` not needed + if (data->ReadEntity (nsub2, i2,"face_bound", ach, STANDARD_TYPE(StepShape_FaceBound), anent2)) + aBounds->SetValue(i2, anent2); + } + } } // --- inherited field : faceGeometry --- diff --git a/tests/bugs/step/bug24283_1 b/tests/bugs/step/bug24283_1 new file mode 100644 index 0000000000..10ccbb3460 --- /dev/null +++ b/tests/bugs/step/bug24283_1 @@ -0,0 +1,11 @@ +puts "============" +puts "OCC24283" +puts "============" +puts "" +##################################################### +# STEP read failes to read unbound advanced_face +##################################################### + +ReadStep D [locate_data_file bug24283_spheres.stp] + + diff --git a/tests/bugs/step/bug24283_2 b/tests/bugs/step/bug24283_2 new file mode 100644 index 0000000000..4ef128b19b --- /dev/null +++ b/tests/bugs/step/bug24283_2 @@ -0,0 +1,19 @@ +puts "============" +puts "OCC24283" +puts "============" +puts "" +##################################################### +# STEP read failes to read unbound advanced_face +##################################################### + +stepread [locate_data_file bug24283_spheres.stp] a * +tpcompound result + +vinit +vdisplay result +vfit +vsetdispmode 1 +set only_screen 1 + + +