From 3697d4fa2fc7199ca9356817eb71e12b1091e65e Mon Sep 17 00:00:00 2001
From: kgv <kgv@opencascade.com>
Date: Tue, 12 Mar 2019 04:51:41 +0300
Subject: [PATCH] 0030556: Coding - IGESData_GlobalSection missing member
 initialization in default constructor

IGESData_GlobalSection now initializes class fields.
---
 src/IGESData/IGESData_GlobalSection.cxx | 48 ++++++++++++-------------
 src/IGESData/IGESData_GlobalSection.hxx | 19 ----------
 2 files changed, 24 insertions(+), 43 deletions(-)

diff --git a/src/IGESData/IGESData_GlobalSection.cxx b/src/IGESData/IGESData_GlobalSection.cxx
index 87211099ac..3b8f6989ac 100644
--- a/src/IGESData/IGESData_GlobalSection.cxx
+++ b/src/IGESData/IGESData_GlobalSection.cxx
@@ -11,15 +11,10 @@
 // Alternatively, this file may be used under the terms of Open CASCADE
 // commercial license or contractual agreement.
 
-//#52 rln 06.01.99 writing value 1.e-07
-//gka 19.01.99 changing size of ParamSet
-//#65 rln 12.02.99 S4151 (explicitly force YYMMDD.HHMMSS before Y2000 and YYYYMMDD.HHMMSS after Y2000)
-//#66 rln Setting IGES 5.3 by default
-//#73 rln 10.03.99 S4135: "read.scale.unit" is applied after translation
+#include <IGESData_GlobalSection.hxx>
 
 #include <gp_XYZ.hxx>
 #include <IGESData_BasicEditor.hxx>
-#include <IGESData_GlobalSection.hxx>
 #include <Interface_Check.hxx>
 #include <Interface_FileParameter.hxx>
 #include <Interface_FileReaderData.hxx>
@@ -34,25 +29,19 @@
 #include <UnitsMethods.hxx>
 
 #include <stdio.h>
-// MGE 21/07/98
-//  valeurs en MILLIMETRE pardefaut, reajustable
-//static Standard_Real convunit = 1000.;
+
 //  Routines locales copiant une string [l`ideal serait : astr = astr->Copy()]
 //    et transformant un CString (Hollerith ou non) en HAsciiString non Holl.
 //    et l inverse
-static void CopyString (Handle(TCollection_HAsciiString)& astr);
-
-static void MakeHollerith(const Handle(TCollection_HAsciiString)& astr,
-                          char* text, Standard_Integer& lt);
-
-void CopyString (Handle(TCollection_HAsciiString)& astr)
+static void CopyString (Handle(TCollection_HAsciiString)& astr)
 {
   if (astr.IsNull()) return;   // ne rien faire si String pas definie !
   Handle(TCollection_HAsciiString) S = new TCollection_HAsciiString("");
-  S->AssignCat(astr);  astr = S;
+  S->AssignCat (astr);
+  astr = S;
 }
 
-void MakeHollerith(const Handle(TCollection_HAsciiString)& astr,
+static void MakeHollerith(const Handle(TCollection_HAsciiString)& astr,
    char* text, Standard_Integer& lt)
 {
   lt = 0;  text[0] = '\0';
@@ -63,21 +52,32 @@ void MakeHollerith(const Handle(TCollection_HAsciiString)& astr,
   lt = ln+2;  if (ln >= 10) lt ++;  if (ln >= 100) lt ++;    // strlen text
 }
 
-
 //=======================================================================
 //function : IGESData_GlobalSection
 //purpose  : 
 //=======================================================================
 
-IGESData_GlobalSection::IGESData_GlobalSection ()
+IGESData_GlobalSection::IGESData_GlobalSection()
+: theSeparator        (','),
+  theEndMark          (';'),
+  theIntegerBits      (32), // simple = entier = 32b, double = 64
+  theMaxPower10Single (38),
+  theMaxDigitsSingle  (6),
+  theMaxPower10Double (308),
+  theMaxDigitsDouble  (15),
+  theScale            (1.0),
+  theUnitFlag         (0),
+  theLineWeightGrad   (1),
+  theMaxLineWeight    (0.0),
+  theResolution       (0.0),
+  theMaxCoord         (0.0),
+  hasMaxCoord (Standard_False),
+  theIGESVersion      (11), // IGES 5.3 by default
+  theDraftingStandard (0)
 {
-//  convunit = 1000.;
-  //#73 rln 10.03.99 S4135: "read.scale.unit" is applied after translation
-  //if (Interface_Static::IVal("read.scale.unit") == 1) convunit = 1;
+  //
 }
 
-
-// pourrait etre une methode generale au package en fait
 //=======================================================================
 //function : TranslatedFromHollerith
 //purpose  : 
diff --git a/src/IGESData/IGESData_GlobalSection.hxx b/src/IGESData/IGESData_GlobalSection.hxx
index 4b9f7efe9b..045704f67d 100644
--- a/src/IGESData/IGESData_GlobalSection.hxx
+++ b/src/IGESData/IGESData_GlobalSection.hxx
@@ -44,7 +44,6 @@ public:
 
   DEFINE_STANDARD_ALLOC
 
-  
   //! Creates an empty GlobalSection, ready to be filled,
   //! Warning : No default value is provided
   Standard_EXPORT IGESData_GlobalSection();
@@ -237,19 +236,8 @@ public:
   
   Standard_EXPORT void SetApplicationProtocol (const Handle(TCollection_HAsciiString)& val);
 
-
-
-
-protected:
-
-
-
-
-
 private:
 
-
-
   Standard_Character theSeparator;
   Standard_Character theEndMark;
   Handle(TCollection_HAsciiString) theSendName;
@@ -278,13 +266,6 @@ private:
   Handle(TCollection_HAsciiString) theLastChangeDate;
   Handle(TCollection_HAsciiString) theAppliProtocol;
 
-
 };
 
-
-
-
-
-
-
 #endif // _IGESData_GlobalSection_HeaderFile