From 34e4e9f26e4882f17e9bf8f9caafd5773b76a0b0 Mon Sep 17 00:00:00 2001 From: Benjamin Bihler Date: Wed, 1 Jun 2016 13:24:23 +0200 Subject: [PATCH] 0027491: GeomAdaptor_Curve Is Not Thread-Safe (Anymore?) Added hint about BSpline cache and missing thread-safety to adaptor classes. --- src/Adaptor2d/Adaptor2d_Curve2d.hxx | 4 ++++ src/Adaptor3d/Adaptor3d_Curve.hxx | 4 ++++ src/Adaptor3d/Adaptor3d_Surface.hxx | 4 ++++ src/Geom2dAdaptor/Geom2dAdaptor_Curve.hxx | 4 ++++ src/GeomAdaptor/GeomAdaptor_Curve.hxx | 4 ++++ src/GeomAdaptor/GeomAdaptor_Surface.hxx | 4 ++++ 6 files changed, 24 insertions(+) diff --git a/src/Adaptor2d/Adaptor2d_Curve2d.hxx b/src/Adaptor2d/Adaptor2d_Curve2d.hxx index 5d119884bd..c845bcef7a 100644 --- a/src/Adaptor2d/Adaptor2d_Curve2d.hxx +++ b/src/Adaptor2d/Adaptor2d_Curve2d.hxx @@ -49,6 +49,10 @@ class Geom2d_BSplineCurve; //! the curve by algorithms, which use it. //! A derived concrete class is provided: //! Geom2dAdaptor_Curve for a curve from the Geom2d package. +//! +//! Polynomial coefficients of BSpline curves used for their evaluation are +//! cached for better performance. Therefore these evaluations are not +//! thread-safe and parallel evaluations need to be prevented. class Adaptor2d_Curve2d { public: diff --git a/src/Adaptor3d/Adaptor3d_Curve.hxx b/src/Adaptor3d/Adaptor3d_Curve.hxx index 8e37d2f6ea..647cf03d71 100644 --- a/src/Adaptor3d/Adaptor3d_Curve.hxx +++ b/src/Adaptor3d/Adaptor3d_Curve.hxx @@ -51,6 +51,10 @@ class Geom_BSplineCurve; //! - GeomAdaptor_Curve for a curve from the Geom package //! - Adaptor3d_CurveOnSurface for a curve lying on //! a surface from the Geom package. +//! +//! Polynomial coefficients of BSpline curves used for their evaluation are +//! cached for better performance. Therefore these evaluations are not +//! thread-safe and parallel evaluations need to be prevented. class Adaptor3d_Curve { public: diff --git a/src/Adaptor3d/Adaptor3d_Surface.hxx b/src/Adaptor3d/Adaptor3d_Surface.hxx index 844588c98d..1f5c3061ee 100644 --- a/src/Adaptor3d/Adaptor3d_Surface.hxx +++ b/src/Adaptor3d/Adaptor3d_Surface.hxx @@ -61,6 +61,10 @@ class Adaptor3d_HCurve; //! Warning: All the methods are virtual and implemented with a //! raise to allow to redefined only the methods realy //! used. +//! +//! Polynomial coefficients of BSpline surfaces used for their evaluation are +//! cached for better performance. Therefore these evaluations are not +//! thread-safe and parallel evaluations need to be prevented. class Adaptor3d_Surface { public: diff --git a/src/Geom2dAdaptor/Geom2dAdaptor_Curve.hxx b/src/Geom2dAdaptor/Geom2dAdaptor_Curve.hxx index 3c0b7d5eb3..1bf3d2aa6b 100644 --- a/src/Geom2dAdaptor/Geom2dAdaptor_Curve.hxx +++ b/src/Geom2dAdaptor/Geom2dAdaptor_Curve.hxx @@ -51,6 +51,10 @@ class Geom2d_BSplineCurve; //! An interface between the services provided by any //! curve from the package Geom2d and those required //! of the curve by algorithms which use it. +//! +//! Polynomial coefficients of BSpline curves used for their evaluation are +//! cached for better performance. Therefore these evaluations are not +//! thread-safe and parallel evaluations need to be prevented. class Geom2dAdaptor_Curve : public Adaptor2d_Curve2d { public: diff --git a/src/GeomAdaptor/GeomAdaptor_Curve.hxx b/src/GeomAdaptor/GeomAdaptor_Curve.hxx index 7cf42e600a..62f981a7e0 100644 --- a/src/GeomAdaptor/GeomAdaptor_Curve.hxx +++ b/src/GeomAdaptor/GeomAdaptor_Curve.hxx @@ -52,6 +52,10 @@ class Geom_BSplineCurve; //! This class provides an interface between the services provided by any //! curve from the package Geom and those required of the curve by algorithms which use it. //! Creation of the loaded curve the curve is C1 by piece. +//! +//! Polynomial coefficients of BSpline curves used for their evaluation are +//! cached for better performance. Therefore these evaluations are not +//! thread-safe and parallel evaluations need to be prevented. class GeomAdaptor_Curve : public Adaptor3d_Curve { public: diff --git a/src/GeomAdaptor/GeomAdaptor_Surface.hxx b/src/GeomAdaptor/GeomAdaptor_Surface.hxx index b03243f17e..bef6e8a392 100644 --- a/src/GeomAdaptor/GeomAdaptor_Surface.hxx +++ b/src/GeomAdaptor/GeomAdaptor_Surface.hxx @@ -54,6 +54,10 @@ class Adaptor3d_HCurve; //! surface from the package Geom and those required //! of the surface by algorithms which use it. //! Creation of the loaded surface the surface is C1 by piece +//! +//! Polynomial coefficients of BSpline surfaces used for their evaluation are +//! cached for better performance. Therefore these evaluations are not +//! thread-safe and parallel evaluations need to be prevented. class GeomAdaptor_Surface : public Adaptor3d_Surface { public: