From 090ef040125d33234fa6110f313987a63b4b8701 Mon Sep 17 00:00:00 2001
From: abv <abv@opencascade.com>
Date: Mon, 20 Nov 2017 08:51:32 +0300
Subject: [PATCH] 0029334: Simple offsets complicate geometry

Method BRepOffset::Surface() is used in simple offset algorithm to create offset surface, instead of direct and unconditional construction of new Geom_OffsetSurface instance.

Added test bugs modalg_7 bug29334
---
 src/BRepOffset/BRepOffset_SimpleOffset.cxx |  3 ++-
 tests/bugs/modalg_7/bug29334               | 28 ++++++++++++++++++++++
 2 files changed, 30 insertions(+), 1 deletion(-)
 create mode 100644 tests/bugs/modalg_7/bug29334

diff --git a/src/BRepOffset/BRepOffset_SimpleOffset.cxx b/src/BRepOffset/BRepOffset_SimpleOffset.cxx
index ff585e5153..e021d5e7e5 100644
--- a/src/BRepOffset/BRepOffset_SimpleOffset.cxx
+++ b/src/BRepOffset/BRepOffset_SimpleOffset.cxx
@@ -233,7 +233,8 @@ void BRepOffset_SimpleOffset::FillFaceData(const TopoDS_Face& theFace)
   if (theFace.Orientation() == TopAbs_REVERSED)
     aMult = -1.0;
 
-  aNFD.myOffsetS = new Geom_OffsetSurface(aS, aMult * myOffsetValue, Standard_True);
+  BRepOffset_Status aStatus; // set by BRepOffset::Surface(), could be used to check result...
+  aNFD.myOffsetS = BRepOffset::Surface (aS, aMult * myOffsetValue, aStatus, Standard_True);
   aNFD.myL = TopLoc_Location(); // Null transformation.
 
   // Save offset surface in map.
diff --git a/tests/bugs/modalg_7/bug29334 b/tests/bugs/modalg_7/bug29334
new file mode 100644
index 0000000000..b9b4f7a1ac
--- /dev/null
+++ b/tests/bugs/modalg_7/bug29334
@@ -0,0 +1,28 @@
+puts "# ======================================================================"
+puts "# 0029334: Simple offsets complicate geometry"
+puts "# ======================================================================"
+
+puts "Make box, fillet one of its edges, and extract two planar faces connected by fillet"
+box b 10 10 10
+explode b e
+blend r b 1 b_5
+explode r f
+compound r_1 r_3 r_6 shape
+
+puts "Offset these faces using simple offset algo"
+offsetshapesimple result shape 1
+
+puts "Verify that all faces of the result are either planes or cylinders"
+set i 1
+foreach f [explode result f] {
+  mksurface surf_$i $f
+  set surf_dump [dump surf_$i] 
+  if { [regexp {Offset} $surf_dump] } {
+    puts "Error: surface $i is offset, should be plane or cylinder"
+  }
+  if { ! [regexp {Plane|CylindricalSurface} $surf_dump] } {
+    puts "Error: surface $i is not plane or cylinder"
+  }
+  incr i
+}
+